build: update to rules_nodejs v1.4.0 #18687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to the latest rules_nodejs version. Also removes the unnecessary Yarn resolution since we sent an upstream fix to update to the latest jasmine version. See: bazel-contrib/rules_nodejs@98fab93
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
josephperrott
added
pr: lgtm
action: merge
mmalerba
added a commit
that referenced
this pull request
Mar 6, 2020
Updates to the latest rules_nodejs version. Also removes the unnecessary Yarn resolution since we sent an upstream fix to update to the latest jasmine version. See: bazel-contrib/rules_nodejs@98fab93
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest rules_nodejs version. Also removes the
unnecessary Yarn resolution since we sent an upstream fix to
update to the latest jasmine version. See: bazel-contrib/rules_nodejs@98fab93
The manifest
@bazel/typescriptpatch had to be updated due to recent changes totsc_wrapped. I'm hoping we can spend some time porting these changes upstream.It's unclear though if its worth the effort if we eventually simply use
tscin Bazel.