build: avoid file collisions in docs-content #18691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
googlebot
added
the
cla: yes
|
Looks like a formatting lint warning |
Currently we always move guides, overviews, example files into the `docs-content` by their basename. This means that no guides, overviews, example files with the same name can exist. The last one being processed by Bazel overwrites the previous ones. This can be currently observed in the docs where the custom form-field control example incorrectly displays the MDC-based form-field custom control example. Ultimately breaking StackBlitz. For example: https://material.angular.io/guide/creating-a-custom-form-field-control. Click on the first example, and open it on StackBlitz. We can fix this by preserving the directories where the guides, overviews and example files have been copied from. This also allows us to have multiple overviews in a package without the risk of collisions. Note: Needs an corresponding change in the material.angular.io repo.
devversion
force-pushed
the
build/avoid-colliding-docs-content
branch
from
b5a72a1 to
8dffd61
Compare
|
@jelbourn Fixed. |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
mmalerba
added a commit
that referenced
this pull request
Mar 6, 2020
Currently we always move guides, overviews, example files into the `docs-content` by their basename. This means that no guides, overviews, example files with the same name can exist. The last one being processed by Bazel overwrites the previous ones. This can be currently observed in the docs where the custom form-field control example incorrectly displays the MDC-based form-field custom control example. Ultimately breaking StackBlitz. For example: https://material.angular.io/guide/creating-a-custom-form-field-control. Click on the first example, and open it on StackBlitz. We can fix this by preserving the directories where the guides, overviews and example files have been copied from. This also allows us to have multiple overviews in a package without the risk of collisions. Note: Needs an corresponding change in the material.angular.io repo.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always move guides, overviews, example files into
the
docs-contentby their basename. This means that no guides,overviews, example files with the same name can exist. The last
one being processed by Bazel overwrites the previous ones.
This can be currently observed in the docs where the custom
form-field control example incorrectly displays the MDC-based
form-field custom control example. Ultimately breaking the StackBlitz.
For example: https://material.angular.io/guide/creating-a-custom-form-field-control.
Click on the first example, and open it on StackBlitz.
We can fix this by preserving the directories where the guides,
overviews and example files have been copied from. This also allows
us to have multiple overviews in a package without the risk of collisions.
Note: Needs an corresponding change in the material.angular.io repo.