-
Notifications
You must be signed in to change notification settings - Fork 6.8k
support an optional trackBy function in FlatTreeControl #18708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is similar to trackBy in *ngFor and is critical for those of us who use the redux pattern (i.e. NGRX) since we frequently replace our node references with modified copies from the Store (as opposed to changing the state within the node objects themselves)
Two comments:
To resolve this, we can add a new type You can take the code from this commit and apply it to this PR and verify that it fits your use case: andrewseguin@d0c1089 |
Hi! Thank you for the suggested changes - I've applied them, but I'm not sure what these failing CircleCI tests are |
|
Hello! Fixed up the failing tests, I'm not sure what that last check is though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…18708) This is similar to trackBy in *ngFor and is important for those who use the redux pattern (i.e. NGRX) since node references are frequently replaced with modifies instances from the Store (as opposed to changing the state within the node objects themselves)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This is similar to trackBy in *ngFor and is critical for those of us who
use the redux pattern (i.e. NGRX) since we frequently replace our node references with
modified copies from the Store (as opposed to changing the state within the node objects
themselves)