Skip to content

build: add clipboard to dev app #18715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 4, 2020

Currently we don't have an easy way of debugging the cdk/clipboard module locally. These changes add a page to the dev app.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Mar 4, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 4, 2020
@crisbeto crisbeto force-pushed the clipboard-dev-app branch from ae2abbc to 971598f Compare March 4, 2020 21:13
@crisbeto crisbeto requested a review from a team as a code owner March 4, 2020 21:13
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from Paul's comment

@mmalerba mmalerba added the lgtm label Mar 4, 2020
Currently we don't have an easy way of debugging the `cdk/clipboard` module locally. These changes add a page to the dev app.
@crisbeto crisbeto force-pushed the clipboard-dev-app branch from 971598f to d7b87e5 Compare March 5, 2020 06:31
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 9da22e4 into angular:master Mar 5, 2020
mmalerba added a commit that referenced this pull request Mar 6, 2020
Currently we don't have an easy way of debugging the `cdk/clipboard` module locally. These changes add a page to the dev app.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants