build: include tslib as explicit dependency for ng_package rule
#18720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a previous commit we removed `tslib` from the rollup globals so that `ng_package` can bundle `tslib` into the UMD bundles. This works fine in non-sandbox environments (e.g. windows), but doesn't work in sandbox environments because `ng_package` does not bring in transitive dependencies from entry-points. Hence we need to explicitly pass in `tslib` as dependency for `ng_package`. This matches what `angular/angular` does for including tslib.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
josephperrott
added
lgtm
action: merge
mmalerba
added a commit
that referenced
this pull request
Mar 6, 2020
In a previous commit we removed `tslib` from the rollup globals so that `ng_package` can bundle `tslib` into the UMD bundles. This works fine in non-sandbox environments (e.g. windows), but doesn't work in sandbox environments because `ng_package` does not bring in transitive dependencies from entry-points. Hence we need to explicitly pass in `tslib` as dependency for `ng_package`. This matches what `angular/angular` does for including tslib.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous commit we removed
tslibfrom the rollup globals sothat
ng_packagecan bundletslibinto the UMD bundles.This works fine in non-sandbox environments (e.g. windows), but doesn't
work in sandbox environments because
ng_packagedoes not bring intransitive dependencies from entry-points. Hence we need to explicitly
pass in
tslibas dependency forng_package. This matches whatangular/angulardoes for including tslib.