Skip to content

refactor(column-resize): simplify RTL handling #18835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

crisbeto
Copy link
Member

The various column resize components had a ton of boilerplate just to apply an ltr/rtl class. We can avoid it altogether by using [dir='rtl'] like we do in all of the other components.

The various column resize components had a ton of boilerplate just to apply an ltr/rtl class. We can avoid it altogether by using `[dir='rtl']` like we do in all of the other components.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Mar 15, 2020
@crisbeto crisbeto requested a review from andrewseguin as a code owner March 15, 2020 16:01
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2020
@kseamon
Copy link
Collaborator

kseamon commented Mar 16, 2020

@crisbeto
Copy link
Member Author

I'm not sure why that table says that IE doesn't support it, because it definitely does from my testing. We've been using the attribute selector in all other components to support RTL.

@kseamon
Copy link
Collaborator

kseamon commented Mar 16, 2020

If you've tested it and it still works as expected, then LGTM.

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 16, 2020
@mmalerba mmalerba merged commit f9fffab into angular:master Mar 16, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants