build: resolve module names in circular deps test #18957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the circular dependencies test only resolves relative imports. It does not resolve module names to packages/entry-points which are part of the Angular Components repository. To ensure that such repo-specific module names are resolved, we add a custom module resolver. This helps us making the circular deps test future-proof in case an entry-point uses module names. Within an entry-point circular dependencies could be also created with module name imports.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
|
Joey's partially OOO today, so I'll merge this now and we can do a follow-up if he proposes any changes |
jelbourn
pushed a commit
that referenced
this pull request
Mar 31, 2020
Currently the circular dependencies test only resolves relative imports. It does not resolve module names to packages/entry-points which are part of the Angular Components repository. To ensure that such repo-specific module names are resolved, we add a custom module resolver. This helps us making the circular deps test future-proof in case an entry-point uses module names. Within an entry-point circular dependencies could be also created with module name imports. (cherry picked from commit 2fce0c6)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the circular dependencies test only resolves
relative imports. It does not resolve module names
to packages/entry-points which are part of the Angular
Components repository.
To ensure that such repo-specific module names are resolved, we
add a custom module resolver. This helps us making the circular deps
test future-proof in case an entry-point uses module names.
Within an entry-point circular dependencies could be also created
with module name imports.
@josephperrott Sorry. I would have commented on the original PR, but I didn't have a chance to have anther look as the PR still had
merge readyapplied and got merged quickly.