-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs: add matButtonModule to fix example #19041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@santoshyadav198613 Is this ready for review? If not, can you please convert this to a draft. If this is ready: I don't think any example in |
Hi @devversion , The UI is broken as we are using mat-button in sample code template, but not importing it. |
@santoshyadav198613 Thanks for clarifying. Can you please share where you see the UI broken? I've looked in the docs site, and also can't see |
Hi @devversion , its normal button, also If this works will add it to a11y button as well, as I think we should follow the material design for docs. |
Ahh. I see. You moved the changes over to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Thanks! Can you please fix the import?
@@ -1,6 +1,7 @@ | |||
import {TextFieldModule} from '@angular/cdk/text-field'; | |||
import {CommonModule} from '@angular/common'; | |||
import {NgModule} from '@angular/core'; | |||
import {MatButtonModule} from '@angular/material/Button'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be lower-case button
.
import {MatButtonModule} from '@angular/material/Button'; | |
import {MatButtonModule} from '@angular/material/button'; |
OMG, how can I do that, thanks for pointing out, looks like I was too tired :) |
(cherry picked from commit 1cf4048)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.