Skip to content

build: update to latest dev-infra package changes #19129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020

Conversation

devversion
Copy link
Member

Updates to the latest changes of the shared dev-infra
package. We recently landed a few improvements for the
circular-deps tool there. i.e. more deterministic order
of circular dependencies in the golden (hence the update).

@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Apr 21, 2020
@devversion devversion requested review from jelbourn and a team as code owners April 21, 2020 09:38
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 21, 2020
@devversion devversion force-pushed the build/update-dev-infra-package branch from 9874a47 to fe1e277 Compare April 21, 2020 10:25
Updates to the latest changes of the shared dev-infra
package. We recently landed a few improvements for the
circular-deps tool there. i.e. more deterministic order
of circular dependencies in the golden (hence the update).

Also fixes missing peer dependencies for the dev-infra package.
@devversion devversion force-pushed the build/update-dev-infra-package branch from fe1e277 to 0f1fe00 Compare April 21, 2020 12:49
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 22, 2020
@jelbourn jelbourn merged commit 41be7a0 into angular:master Apr 22, 2020
jelbourn pushed a commit that referenced this pull request Apr 22, 2020
Updates to the latest changes of the shared dev-infra
package. We recently landed a few improvements for the
circular-deps tool there. i.e. more deterministic order
of circular dependencies in the golden (hence the update).

Also fixes missing peer dependencies for the dev-infra package.
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
Updates to the latest changes of the shared dev-infra
package. We recently landed a few improvements for the
circular-deps tool there. i.e. more deterministic order
of circular dependencies in the golden (hence the update).

Also fixes missing peer dependencies for the dev-infra package.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants