Skip to content

feat(tooltip/testing): add test harness for mat-tooltip #19144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

feat(tooltip/testing): add test harness for mat-tooltip #19144

merged 1 commit into from
May 26, 2020

Conversation

crisbeto
Copy link
Member

This is redo of #16676. Adds a test harness for mat-tooltip, as well as an API to move the pointer away from an element, as an opposite to TestElement.hover.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2020
@crisbeto crisbeto marked this pull request as ready for review April 22, 2020 20:36
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Apr 22, 2020
jelbourn
jelbourn reviewed Apr 22, 2020
View reviewed changes
@crisbeto
feat(tooltip/testing): add test harness for mat-tooltip
2128e71 
This is redo of angular#16676. Adds a test harness for `mat-tooltip`, as well as an API to move the pointer away from an element, as an opposite to `TestElement.hover`.
@crisbeto
Copy link
Member Author

I've addressed the feedback @jelbourn.

jelbourn
jelbourn approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 23, 2020
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed target: minor This PR is targeted for the next minor release labels May 9, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 9, 2020
@jelbourn jelbourn merged commit 44accd6 into angular:master May 26, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba