refactor: cleanup fake event dispatch utilities #19151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up the fake event dispatch utiltities: 1. `dispatchMouseEvent` accepts an actual mouse event. This has been introduced with [this commit](04bf3d1). If a mouse event has already been created, then it can be just dispatched, but doesn't need to go through `dispatchMouseEvent` which primarily is a shorthand for creating an event and dispatching it. 2. `dispatchEvent` helper should use a generic so that we don't need to cast events unnecessarily. 3. `createMouseEvent` should not accept `x` and `y`. This is ambiguous. It's not clear what coordinates are expected. To improve this, parameters are now explicit, and a better comment has been added.
googlebot
added
the
cla: yes
devversion
added
the
target: patch
jelbourn
pushed a commit
that referenced
this pull request
Apr 24, 2020
Cleans up the fake event dispatch utiltities: 1. `dispatchMouseEvent` accepts an actual mouse event. This has been introduced with [this commit](04bf3d1). If a mouse event has already been created, then it can be just dispatched, but doesn't need to go through `dispatchMouseEvent` which primarily is a shorthand for creating an event and dispatching it. 2. `dispatchEvent` helper should use a generic so that we don't need to cast events unnecessarily. 3. `createMouseEvent` should not accept `x` and `y`. This is ambiguous. It's not clear what coordinates are expected. To improve this, parameters are now explicit, and a better comment has been added.
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
Cleans up the fake event dispatch utiltities: 1. `dispatchMouseEvent` accepts an actual mouse event. This has been introduced with [this commit](04bf3d1). If a mouse event has already been created, then it can be just dispatched, but doesn't need to go through `dispatchMouseEvent` which primarily is a shorthand for creating an event and dispatching it. 2. `dispatchEvent` helper should use a generic so that we don't need to cast events unnecessarily. 3. `createMouseEvent` should not accept `x` and `y`. This is ambiguous. It's not clear what coordinates are expected. To improve this, parameters are now explicit, and a better comment has been added.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the fake event dispatch utiltities:
dispatchMouseEventaccepts an actual mouse event. This has beenintroduced with this commit. If a mouse event has already been created,
then it can be just dispatched, but doesn't need to go through
dispatchMouseEventwhich primarily is a shorthand for creatingan event and dispatching it.
dispatchEventhelper should use a generic so that we don'tneed to cast events unnecessarily.
createMouseEventshould not acceptxandy. This is ambiguous.It's not clear what coordinates are expected. To improve this,
parameters are now explicit, and a better comment has been added.