fix(google-maps): incorrect variable access for server-side rendering check #19166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
… check We added a SSR check to the google-maps window info directive, but when this PR landed in the patch branch, the variable names no longer matched. The variable for the `_infoWindow` has been made public with 3e00f4c, but this change did not land in the patch branch as it targets a next minor release.
devversion
force-pushed
the
fix/patch-branch-map-info
branch
from
b467469 to
8f1b01d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a SSR check to the google-maps window info directive, but when
this PR landed in the patch branch, the variable names no longer matched.
The variable for the
_infoWindowhas been made public with 3e00f4c, butthis change did not land in the patch branch as it targets a next minor release.