Skip to content

docs: prevent form submission in examples #19240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

docs: prevent form submission in examples #19240

merged 1 commit into from
May 7, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 3, 2020

There were a couple of examples which would trigger a page refresh if the user pressed one of the buttons, because we were using a form without preventing its default action.

@crisbeto
docs: prevent form submission in examples
32012c5 
There were a couple of examples which would trigger a page refresh if the user pressed one of the buttons, because we were using a form without preventing its default action.
@crisbeto crisbeto added docs This issue is related to documentation merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels May 3, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner May 3, 2020 13:56
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 3, 2020
jelbourn
jelbourn approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels May 4, 2020
mmalerba
mmalerba approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 1bec9dc into angular:master May 7, 2020
jelbourn pushed a commit that referenced this pull request May 7, 2020
@crisbeto @jelbourn
docs: prevent form submission in examples (#19240)
98f4afa 
There were a couple of examples which would trigger a page refresh if the user pressed one of the buttons, because we were using a form without preventing its default action.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @mmalerba @googlebot