build: apply angular bazel ng_module fix to unblock framework #19276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
devversion
added
the
P3
devversion
added
the
blocked
|
Marking as blocked temporarily until it's clear whether the framework PR will land or not. |
Due to our weird cyclic dependency with the framework repository, we need to apply changes from angular/angular#36971 before the PR can actually land in framework. This is because the changes of that PR fail in the components repo job as we apply patches that conflict with the new changes. At the same time though, we cannot make the components repo compatible until the framework PR landed. We work around this as usually done, by applying the upstream changes through a patch. Then we can resolve conflicts and the framework PR can land. Eventually we can then remove the patch again from the components repo.
devversion
force-pushed
the
build/prepare-ng-bazel-update
branch
from
693ed56 to
030609f
Compare
devversion
added
action: merge
|
Looks the PR is upstream now approved and we are good to go with landing this.. so that we can clean up things upstream in the |
andrewseguin
pushed a commit
that referenced
this pull request
Jun 9, 2020
Due to our weird cyclic dependency with the framework repository, we need to apply changes from angular/angular#36971 before the PR can actually land in framework. This is because the changes of that PR fail in the components repo job as we apply patches that conflict with the new changes. At the same time though, we cannot make the components repo compatible until the framework PR landed. We work around this as usually done, by applying the upstream changes through a patch. Then we can resolve conflicts and the framework PR can land. Eventually we can then remove the patch again from the components repo.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to our weird cyclic dependency with the framework repository,
we need to apply changes from angular/angular#36971
before the PR can actually land in framework. This is because the
changes of that PR fail in the components repo job as we apply patches
that conflict with the new changes.
At the same time though, we cannot make the components repo compatible
until the framework PR landed. We work around this as usually done, by
applying the upstream changes through a patch. Then we can resolve
conflicts and the framework PR can land. Eventually we can then
remove the patch again from the components repo.