Skip to content

refactor(clipboard): remove deprecated APIs for version 10 #19362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

refactor(clipboard): remove deprecated APIs for version 10 #19362

merged 1 commit into from
May 21, 2020

Conversation

crisbeto
Copy link
Member

Changes the APIs that have been marked as deprecated for v10.

BREAKING CHANGES:

  • The copied event from cdkCopyToClipboard has been renamed to cdkCopyToClipboardCopied.
  • The _ngZone parameter in the CdkCopyToClipboard constructor is now required.

@crisbeto
refactor(clipboard): remove deprecated APIs for version 10
4d63bf2 
Changes the APIs that have been marked as deprecated for v10.

BREAKING CHANGES:
* The `copied` event from `cdkCopyToClipboard` has been renamed to `cdkCopyToClipboardCopied`.
* The `_ngZone` parameter in the `CdkCopyToClipboard` constructor is now required.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels May 14, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone May 14, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 14, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 14, 2020
jelbourn
jelbourn approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 3d141ea into angular:master May 21, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @googlebot