Skip to content

build: set dev app density class on body #19424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

crisbeto
Copy link
Member

Sets the desnity class on the body, rather than the layout element. We'll need this for overlay-based components that implement the density system.

Sets the desnity class on the body, rather than the layout element. We'll need this for overlay-based components that implement the density system.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels May 22, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner May 22, 2020 18:00
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 22, 2020
@devversion
Copy link
Member

@crisbeto I think I did it intentionally that way because focused tasks (i.e. overlays) should never scale per density according to the Material Design specification.

@crisbeto
Copy link
Member Author

I've definitely seen different densities for some of the overlay-based components in the spec. E.g. see the "desktop" vs "mobile" in the menu spec: https://material.io/components/menus#specs

@devversion
Copy link
Member

devversion commented May 22, 2020

To be clear: I'm not concerned with adding this to the body. We can do this either way, but this is just my understanding based on the dedicated density Material Design section. e.g. it says specifically about the menu:

Don’t increase the density of components that involve focused tasks, such as interacting with a dropdown menu or picker.

I might be misinterpreting that though? any ideas?

@crisbeto
Copy link
Member Author

I understand what you mean and it seems like you're interpreting it correctly, but the menu spec contradicts it so I can also see it going either way. IMO we still need this on the body so we can test components that support density and are placed in an overlay.

@devversion
Copy link
Member

Yeah, I don't think it matters too much. The fact that the spec is contradictory here, doesn't help here.

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels May 25, 2020
@jelbourn jelbourn added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jun 3, 2020
@jelbourn jelbourn merged commit b365ba7 into angular:master Jun 3, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants