Skip to content

fix(overlay): resolve circular dependency #19433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

crisbeto
Copy link
Member

Resolves a circular dependency between a couple of the classes in cdk/overlay.

Resolves a circular dependency between a couple of the classes in `cdk/overlay`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 24, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners May 24, 2020 12:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 24, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 26, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 7037c3a into angular:master Jun 5, 2020
jelbourn pushed a commit that referenced this pull request Jun 5, 2020
Resolves a circular dependency between a couple of the classes in `cdk/overlay`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants