refactor: update snippets/embedded example comments in material docs md to reflect new API (chips, menu, tabs) #19486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
May 30, 2020
src/material/chips/chips.md
Outdated
| <mat-chip>Dal</mat-chip> | ||
| </mat-chip-list> | ||
| ``` | ||
| <!-- example{{"example":"chips-overview", |
There was a problem hiding this comment.
Looks like there's a syntax error here. There's a { instead of ( right after example.
src/material/menu/menu.md
Outdated
| </button> | ||
| ``` | ||
| <!-- example({"example":"menu-overview", | ||
| "file":"menu-overview-example.html", |
There was a problem hiding this comment.
Everywhere else we have a space after the colon in object literals, we should probably do the same here too.
jelbourn
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove static code snippets in material docs and replace them with embedded examples in compact view.
Add regions in component examples.