Skip to content

fix(google-maps): add exportAs to all directives #19522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2020
Merged

fix(google-maps): add exportAs to all directives #19522

merged 1 commit into from
Jun 5, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 3, 2020

Currently none of the Google Maps-related directives have an exportAs which makes them difficult to reference inside templates.

Fixes #19462.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 3, 2020
@crisbeto crisbeto requested a review from a team as a code owner June 3, 2020 06:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 3, 2020
@crisbeto
fix(google-maps): add exportAs to all directives
0d95885 
Currently none of the Google Maps-related directives have an `exportAs` which makes them difficult to reference inside templates.

Fixes angular#19462.
@crisbeto crisbeto force-pushed the 19462/google-maps-export-as branch from 560aa1f to 0d95885 Compare June 3, 2020 06:49
@devversion devversion added the lgtm label Jun 3, 2020
josephperrott
josephperrott approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 3, 2020
jelbourn
jelbourn approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jun 5, 2020
@jelbourn jelbourn merged commit 6544de8 into angular:master Jun 5, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

google-maps: expose directives for template reference usage
5 participants
@crisbeto @jelbourn @devversion @josephperrott @googlebot