-
Notifications
You must be signed in to change notification settings - Fork 6.8k
test(radio): add performance tests for mat-radio-button #19552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7f6e4a4
test(radio): add performance tests for mat-radio-button
wagnermaciel c942357
fixup! test(radio): add performance tests for mat-radio-button
wagnermaciel 9a8c016
fixup! test(radio): add performance tests for mat-radio-button
wagnermaciel 3decf7f
fixup! test(radio): add performance tests for mat-radio-button
wagnermaciel b0f5dfc
fixup! test(radio): add performance tests for mat-radio-button
wagnermaciel 98e5a75
fixup! test(radio): add performance tests for mat-radio-button
wagnermaciel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
load("@npm_angular_dev_infra_private//benchmark/component_benchmark:component_benchmark.bzl", "component_benchmark") | ||
|
||
# TODO(wagnermaciel): Update this target to provide indigo-pink in a way that doesn't require having to import it with | ||
# stylesUrls inside the components once `component_benchmark` supports asset injection. | ||
|
||
component_benchmark( | ||
name = "benchmark", | ||
driver = ":radio.perf-spec.ts", | ||
driver_deps = [ | ||
"@npm//@angular/dev-infra-private", | ||
"@npm//protractor", | ||
"@npm//@types/jasmine", | ||
], | ||
ng_deps = [ | ||
"@npm//@angular/core", | ||
"@npm//@angular/platform-browser", | ||
"//src/material/radio", | ||
], | ||
ng_srcs = [":app.module.ts"], | ||
prefix = "", | ||
styles = ["//src/material/prebuilt-themes:indigo-pink"], | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
import {Component, NgModule, ViewEncapsulation} from '@angular/core'; | ||
import {BrowserModule} from '@angular/platform-browser'; | ||
import {MatRadioModule} from '@angular/material/radio'; | ||
|
||
/** component: mat-radio-button */ | ||
|
||
@Component({ | ||
selector: 'app-root', | ||
template: ` | ||
<button id="show-two" (click)="showTwo()">Show Two</button> | ||
<button id="hide-two" (click)="hideTwo()">Hide Two</button> | ||
|
||
<button id="show-ten" (click)="showTen()">Show Ten</button> | ||
<button id="hide-ten" (click)="hideTen()">Hide Ten</button> | ||
|
||
<mat-radio-group aria-label="Select an option" *ngIf="isTwoVisible"> | ||
<mat-radio-button value="1" id="btn-1">Option 1</mat-radio-button> | ||
<mat-radio-button value="2" id="btn-2">Option 2</mat-radio-button> | ||
</mat-radio-group> | ||
|
||
<mat-radio-group aria-label="Select an option" *ngIf="isTenVisible"> | ||
<mat-radio-button value="1">Option 1</mat-radio-button> | ||
<mat-radio-button value="2">Option 2</mat-radio-button> | ||
<mat-radio-button value="3">Option 3</mat-radio-button> | ||
<mat-radio-button value="4">Option 4</mat-radio-button> | ||
<mat-radio-button value="5">Option 5</mat-radio-button> | ||
<mat-radio-button value="6">Option 6</mat-radio-button> | ||
<mat-radio-button value="7">Option 7</mat-radio-button> | ||
<mat-radio-button value="8">Option 8</mat-radio-button> | ||
<mat-radio-button value="9">Option 9</mat-radio-button> | ||
<mat-radio-button value="10">Option 10</mat-radio-button> | ||
</mat-radio-group> | ||
`, | ||
encapsulation: ViewEncapsulation.None, | ||
styleUrls: ['//src/material/core/theming/prebuilt/indigo-pink.css'], | ||
}) | ||
export class RadioBenchmarkApp { | ||
isTwoVisible = false; | ||
isTenVisible = false; | ||
|
||
showTwo() { this.isTwoVisible = true; } | ||
hideTwo() { this.isTwoVisible = false; } | ||
|
||
showTen() { this.isTenVisible = true; } | ||
hideTen() { this.isTenVisible = false; } | ||
} | ||
|
||
|
||
@NgModule({ | ||
declarations: [RadioBenchmarkApp], | ||
imports: [ | ||
BrowserModule, | ||
MatRadioModule, | ||
], | ||
providers: [], | ||
bootstrap: [RadioBenchmarkApp], | ||
}) | ||
export class AppModule {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
import {$, browser} from 'protractor'; | ||
import {runBenchmark} from '@angular/dev-infra-private/benchmark/driver-utilities'; | ||
|
||
describe('radio button performance benchmarks', () => { | ||
beforeAll(() => { | ||
browser.rootEl = '#root'; | ||
}); | ||
|
||
it('renders two radio buttons', async() => { | ||
await runBenchmark({ | ||
id: 'render-two-radio-buttons', | ||
url: '', | ||
ignoreBrowserSynchronization: true, | ||
params: [], | ||
prepare: async () => await $('#hide-two').click(), | ||
work: async () => await $('#show-two').click(), | ||
}); | ||
}); | ||
|
||
it('renders ten radio buttons', async() => { | ||
await runBenchmark({ | ||
id: 'render-ten-radio-buttons', | ||
url: '', | ||
ignoreBrowserSynchronization: true, | ||
params: [], | ||
prepare: async () => await $('#hide-ten').click(), | ||
work: async () => await $('#show-ten').click(), | ||
}); | ||
}); | ||
|
||
it('changing between radio buttons', async() => { | ||
await runBenchmark({ | ||
id: 'click-radio-button', | ||
url: '', | ||
ignoreBrowserSynchronization: true, | ||
params: [], | ||
setup: async() => await $('#show-two').click(), | ||
prepare: async() => await $('#btn-1').click(), | ||
work: async () => await $('#btn-2').click(), | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: Should we disable browser synchronization by default? We set it quite often and it feels unnecessary to repeat that everywhere? Surely can be a follow-up 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, should be a simple change 👍