feat(material/form-field-custom-control): custom phone input autoadvance #19650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically focus the next input when done with the previous one. Allow autofocusing backward when pressing backspace. onContainerClick now focuses on the last filled input on click. Using maxLength on the inputs to not allow more characters than the size of the input. Fixes #13195
googlebot
added
the
cla: yes
mmalerba
reviewed
Jun 16, 2020
...onents-examples/material/form-field/form-field-custom-control/example-tel-input-example.html
Outdated
Show resolved
Hide resolved
...-examples/material/form-field/form-field-custom-control/form-field-custom-control-example.ts
Outdated
Show resolved
Hide resolved
...-examples/material/form-field/form-field-custom-control/form-field-custom-control-example.ts
Outdated
Show resolved
Hide resolved
...-examples/material/form-field/form-field-custom-control/form-field-custom-control-example.ts
Outdated
Show resolved
Hide resolved
...onents-examples/material/form-field/form-field-custom-control/example-tel-input-example.html
Outdated
Show resolved
Hide resolved
…umber input Updates styling for form-field-custom-control-example component, multi-line elements in template due to them getting long, argument spacing. Fixes #13195
|
@mmalerba thanks for your feedback. I applied the requested changes. |
mmalerba
approved these changes
Jun 17, 2020
...-examples/material/form-field/form-field-custom-control/form-field-custom-control-example.ts
Outdated
Show resolved
Hide resolved
mmalerba
added
action: merge
mmalerba
added
merge: fix commit message
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Jun 18, 2020
…nce (angular#19650) * feat(material/form-field-custom-control): custom phone input autoadvance Automatically focus the next input when done with the previous one. Allow autofocusing backward when pressing backspace. onContainerClick now focuses on the last filled input on click. Using maxLength on the inputs to not allow more characters than the size of the input. Fixes angular#13195 * style(material/form-field-custom-control): styling update for phone number input Updates styling for form-field-custom-control-example component, multi-line elements in template due to them getting long, argument spacing. Fixes angular#13195 * style(material/form-field-custom-control): removes unnecessary !! from autoFocusNext * Merge remote-tracking branch 'upstream/master' into phone-input-auto-advance
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically focus the next input when done with the previous one. Allow autofocusing backward when pressing backspace. onContainerClick now focuses on the last filled input on click. Using maxLength on the inputs to not allow more characters than the size of the input.
https://medium.com/@wildhammer/angular-material-phone-input-2283c7bc3372
Fixes #13195