perf(table): Use only one column classname and do string interpolatio… #19743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n once per column
googlebot
added
the
cla: yes
jelbourn
added
target: minor
|
Leaving |
crisbeto
approved these changes
Jun 24, 2020
|
The biggest change here comes from only adding one css class instead of 2, but spread across thousands of cells the concatenation has a small impact as well. |
andrewseguin
approved these changes
Jun 25, 2020
andrewseguin
added
needs rebase
and removed
cla: yes
|
Sorry this took so long to get in. We likely ran into failures internally from this. If you'd still like to land it, feel free to reopen a new rebased PR and we can take another shot at it |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n once per column
In the "Table with sticky headers, footers and columns" example which has 10 rows, this roughly halves time spent on computing and adding these classes (3.5ms -> 1.8ms), but for tables with more rows/columns the effect is worthwhile.
This is potentially a slightly breaking change as there could be apps using MatTable that are depending on the Cdk classes for something.