Skip to content

fix(google-maps): rendering blank if custom options with no center are provided #19916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2020
Merged

fix(google-maps): rendering blank if custom options with no center are provided #19916

merged 1 commit into from
Jul 11, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 8, 2020

If an options object without a center is passed to the Google Maps API, it'll render a grey rectangle which looks broken. These changes make sure that we always pass in a center so something is rendered.

Fixes #19908.

@crisbeto
fix(google-maps): rendering blank if custom options with no center ar…
e4da9eb 
…e provided

If an options object without a `center` is passed to the Google Maps API, it'll render a grey rectangle which looks broken. These changes make sure that we always pass in a `center` so something is rendered.

Fixes angular#19908.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 8, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 8, 2020
jelbourn
jelbourn approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 8, 2020
@mmalerba mmalerba merged commit 9ce2a90 into angular:master Jul 11, 2020
mmalerba pushed a commit that referenced this pull request Jul 11, 2020
@crisbeto @mmalerba
fix(google-maps): rendering blank if custom options with no center ar…
a34e6bb 
…e provided (#19916)

If an options object without a `center` is passed to the Google Maps API, it'll render a grey rectangle which looks broken. These changes make sure that we always pass in a `center` so something is rendered.

Fixes #19908.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google Map is Empty after Implement Options
4 participants
@crisbeto @jelbourn @googlebot @mmalerba