Skip to content

fix(material-experimental/mdc-snack-bar): error during server-side rendering #19922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 9, 2020

Fixes an error that the MDC snack bar throws during server-side rendering, because MDC is using some browser APIs. Also sets up SSR testing for the new module.

…ndering

Fixes an error that the MDC snack bar throws during server-side rendering, because MDC is using some browser APIs. Also sets up SSR testing for the new module.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jul 9, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 9, 2020
@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2020
@mmalerba mmalerba merged commit 912ad8d into angular:master Jul 10, 2020
mmalerba pushed a commit that referenced this pull request Jul 10, 2020
…ndering (#19922)

Fixes an error that the MDC snack bar throws during server-side rendering, because MDC is using some browser APIs. Also sets up SSR testing for the new module.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants