Skip to content

refactor(table-benchmark): move template to a separate html file #19977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2020

Conversation

wagnermaciel
Copy link
Contributor

  • Now that ng_assets has been added to component_benchmark as a way to pass
    html to the ng_module, we can move the html out of our component decorators
    and into their own html files.

* Now that ng_assets has been added to component_benchmark as a way to pass
  html to the ng_module, we can move the html out of our component decorators
  and into their own html files.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2020
@wagnermaciel wagnermaciel marked this pull request as ready for review July 15, 2020 05:19
@wagnermaciel wagnermaciel requested a review from a team as a code owner July 15, 2020 05:19
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor naming nit

@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Aug 7, 2020
@andrewseguin andrewseguin merged commit 4317a4b into angular:master Aug 12, 2020
andrewseguin pushed a commit that referenced this pull request Aug 12, 2020
)

* refactor(table-benchmark): move template to a separate html file

* Now that ng_assets has been added to component_benchmark as a way to pass
  html to the ng_module, we can move the html out of our component decorators
  and into their own html files.

* fixup! refactor(table-benchmark): move template to a separate html file

* fixup! refactor(table-benchmark): move template to a separate html file

(cherry picked from commit 4317a4b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
@wagnermaciel wagnermaciel deleted the refactor-table-benchmark branch January 14, 2021 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants