Skip to content

docs(stepper): Make CDK stepper example accessible in dark mode. #20013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2020
Merged

docs(stepper): Make CDK stepper example accessible in dark mode. #20013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
093a172
docs(stepper): Make CDK stepper example accessible in dark mode.
walvekarnikhil Jul 16, 2020
9255682
Changing order of styles.
walvekarnikhil Jul 18, 2020
46da02d
Triggering CircleCI build again.
walvekarnikhil Jul 18, 2020
2aeac3e
Removing color inherit, since it is not required.
walvekarnikhil Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions ...omponents-examples/cdk/stepper/cdk-custom-stepper-without-form/example-custom-stepper.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.example-container {
border: 1px solid black;
border: 1px solid;
padding: 10px;
margin: 10px;
}
Expand All @@ -10,24 +10,21 @@
margin-top: 10px;
}

.example-active {
color: blue;
}

.example-step {
background: transparent;
border: 0;
margin: 0 10px;
padding: 10px;
color: black;
color: inherit;
}

.example-step.example-active {
color: blue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can pick a color that stands out both on light and dark backgrounds? I believe the point of this example is to make it stand out to illustrate a point, rather than be pretty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right, we discussed that point but there is an issue with maintaining text contrast for both light and dark mode. So instead of using a neutral color, we ended using the text colors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, the font-weight that you replaced it with should be fine as well.

border-bottom: 1px solid blue;
border-bottom: 1px solid;
font-weight: 600;
}

.example-nav-button {
background: transparent;
border: 0;
color: inherit;
}
9 changes: 5 additions & 4 deletions ...nents-examples/cdk/stepper/cdk-linear-stepper-with-form/example-custom-linear-stepper.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.example-container {
border: 1px solid black;
border: 1px solid;
padding: 10px;
margin: 10px;
}
Expand All @@ -15,15 +15,16 @@
border: 0;
margin: 0 10px;
padding: 10px;
color: black;
color: inherit;
}

.example-step.example-active {
border-bottom: 1px solid blue;
color: blue;
border-bottom: 1px solid;
font-weight: 600;
}

.example-nav-button {
background: transparent;
border: 0;
color: inherit;
}