Skip to content

docs(cdk/drag-drop): clarify usage; to drag a CdkDrag instance #20044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2020
Merged

docs(cdk/drag-drop): clarify usage; to drag a CdkDrag instance #20044

merged 1 commit into from
Jul 21, 2020

Conversation

Splaktar
Copy link
Contributor

No description provided.

@Splaktar Splaktar requested a review from crisbeto July 20, 2020 18:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 20, 2020
@Splaktar Splaktar added area: cdk/drag-drop target: patch This PR is targeted for the next patch release labels Jul 20, 2020
crisbeto
crisbeto approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation lgtm action: merge The PR is ready for merge by the caretaker labels Jul 20, 2020
@wagnermaciel
Copy link
Contributor

@Splaktar This PR has a merge conflict with the 10.1.x branch. We could change this to target: minor or alternatively we could create a new PR against 10.1.x. Your call 👍

@Splaktar Splaktar changed the base branch from master to 10.1.x July 20, 2020 23:42
@Splaktar
Copy link
Contributor Author

Strange. I'm not sure how this one line change could have a merge conflict. I've retargeted the PR at the 10.1.x branch. I don't see any merge conflicts there either, but hopefully this will allow you to get it merged.

@wagnermaciel wagnermaciel merged commit dd02735 into angular:10.1.x Jul 21, 2020
wagnermaciel pushed a commit that referenced this pull request Jul 21, 2020
@Splaktar @wagnermaciel
docs(cdk/drag-drop): clarify usage; to drag a CdkDrag instance (#20044)
0cb302a 
(cherry picked from commit dd02735)
@Splaktar Splaktar deleted the drag-handle-typo branch July 21, 2020 17:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/drag-drop cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Splaktar @wagnermaciel @crisbeto @googlebot