build: update to latest MDC canary and disable slider #20054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
mdc-slider-disable
branch
7 times, most recently
from
7a6b758 to
76dbb9c
Compare
Updates to the latest canary version and temporarily disables the MDC-based slider. We have to disable the slider, because MDC have introduced a completely new implementation that will take some work to reintegrate into our current slider and we don't want our CI to fail until then. I went with this approach of disabling the slider where it's basically a no-op, because we can't simply exclude the build target without modifying a ton of shared files which will be hard to clean up once we start to actually implement it.
crisbeto
force-pushed
the
mdc-slider-disable
branch
from
76dbb9c to
3ed0571
Compare
crisbeto
added
merge safe
P2
andrewseguin
approved these changes
Jul 21, 2020
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 21, 2020
Updates to the latest canary version and temporarily disables the MDC-based slider. We have to disable the slider, because MDC have introduced a completely new implementation that will take some work to reintegrate into our current slider and we don't want our CI to fail until then. I went with this approach of disabling the slider where it's basically a no-op, because we can't simply exclude the build target without modifying a ton of shared files which will be hard to clean up once we start to actually implement it. (cherry picked from commit 0bd626d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the latest canary version and temporarily disables the MDC-based slider. We have to disable the slider, because MDC have introduced a completely new implementation that will take some work to reintegrate into our current slider and we don't want our CI to fail until then.
I went with this approach of disabling the slider where it's basically a no-op, because we can't simply exclude the build target without modifying a ton of shared files which will be hard to clean up once we start to actually implement it.