test: fix listbox spec failing due to keyboard event helper update #20060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We landed two PRs. One that added a new usage of `createKeyboardEvent` and another one that changed the signature of `createKeyboardEvent`. This meant that the first PR adding the new instance does not account for the new function signature and CI/build is failing.
devversion
added
P2
googlebot
added
the
cla: yes
wagnermaciel
added
lgtm
action: merge
wagnermaciel
pushed a commit
that referenced
this pull request
Jul 21, 2020
…20060) We landed two PRs. One that added a new usage of `createKeyboardEvent` and another one that changed the signature of `createKeyboardEvent`. This meant that the first PR adding the new instance does not account for the new function signature and CI/build is failing. (cherry picked from commit e16997c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We landed two PRs. One that added a new usage of
createKeyboardEventand another one that changed the signature of
createKeyboardEvent.This meant that the first PR adding the new instance does not account
for the new function signature and CI/build is failing.