feat(icon): add test harness #20072
Merged
feat(icon): add test harness #20072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets up a test harness for `mat-icon`.
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Jul 22, 2020
| } | ||
|
|
||
| /** Gets the namespace of the icon. */ | ||
| async getNamespace(): Promise<string | null> { |
There was a problem hiding this comment.
I'm not sure about the naming of this and getName. Technically they correspond to two different inputs depending on whether it's an SVG icon (fontSet/svgIcon vs fontIcon/svgIcon), but they basically mean the same thing so I decided to combine them under the same methods. I'm open to suggestions and potentially separating them out so they mirror the inputs.
jelbourn
approved these changes
Jul 22, 2020
wagnermaciel
added a commit
to wagnermaciel/components
that referenced
this pull request
Jul 23, 2020
This reverts commit 092b151. This change adds an import to icon-harness-filters.ts which breaks the internal target which uses this file because it does not have cdk/testing in it's deps.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up a test harness for
mat-icon.