Skip to content

feat(stepper): add test harness #20092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

feat(stepper): add test harness #20092

merged 1 commit into from
Aug 20, 2020

Conversation

crisbeto
Copy link
Member

Adds test harnesses for the stepper-related components.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 25, 2020
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Jul 25, 2020
@crisbeto crisbeto marked this pull request as ready for review July 25, 2020 15:17
@crisbeto crisbeto requested review from jelbourn, mmalerba and a team as code owners July 25, 2020 15:17
crisbeto
crisbeto commented Jul 25, 2020
View reviewed changes
jelbourn
jelbourn approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 27, 2020
@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Jul 27, 2020
mmalerba
mmalerba reviewed Jul 27, 2020
View reviewed changes
@crisbeto crisbeto force-pushed the stepper-harness branch 2 times, most recently from 3ce7823 to ce356a2 Compare July 29, 2020 07:25
mmalerba
mmalerba reviewed Jul 30, 2020
View reviewed changes
mmalerba
mmalerba approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
feat(stepper): add test harness
69ef54a 
Adds test harnesses for the stepper-related components.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 30, 2020
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Aug 20, 2020
@wagnermaciel wagnermaciel merged commit f343ded into angular:master Aug 20, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @mmalerba @googlebot @wagnermaciel