chore: run a11y audits on protractor #2010

devversion · 2016-11-28T19:40:18Z

Fixes accessibility issue in grid-list with role="listitem"
Adds protractor plugin to run aXe-core accessibility audits
Fixes a bunch of a11y issues in the e2e app to make the aXe audits green

jelbourn · 2016-11-28T21:27:35Z

src/e2e-app/e2e-app/e2e-app.html

-<a md-list-item [routerLink]="['radio']">Radios</a>
-<a md-list-item [routerLink]="['tabs']">Tabs</a>
+<!-- To avoid interfering with tests, we are not using the <md-list> element here -->
+<div role="list">


This should be a <md-nav-list>

jelbourn · 2016-11-28T22:01:23Z

tools/axe-protractor/axe-protractor.js

+const {buildMessage} = require('./build-message');
+
+/* Resolved violations */
+const violations = {};


Add more explanation to the comment about the structure of this object.

jelbourn · 2016-11-28T22:02:04Z

tools/axe-protractor/axe-protractor.js

+}
+
+/** Handles the results of axe-core. */
+function handleResults(context, results) {


handleAxeResults?
Also expand the comments with some explanation of what we're doing with those results.

jelbourn · 2016-11-28T22:04:26Z

tools/axe-protractor/build-message.js

@@ -0,0 +1,11 @@
+exports.buildMessage = violation => {


Add description for what this does.

jelbourn · 2016-11-28T22:04:52Z

test/protractor.conf.js

+
+  plugins: [
+    {
+      path: '../tools/axe-protractor/axe-protractor.js',


At which point in the e2e test does axe run?

I added a short comment for it.

Runs the axe-core accessibility checks each time the e2e page changes and Angular is ready.

It basically means that the A11y check runs each time the e2e app changes its page.

Unfortunately we are not that flexible here, because the Protractor API does not provide much hooks (See https://github.com/angular/protractor/blob/master/docs/plugins.md)

jelbourn · 2016-11-29T17:52:48Z

@devversion LGTM, we can iterate on this in the future.

@juliemr are you open to expanding the protractor hooks for plugins? I was thinking it might be useful to have a hook for when the test is complete.

devversion · 2016-12-02T18:22:13Z

@tinayuangao Rebased again 😄

* Fixes accessibility issue in grid-list with `role="listitem"` * Adds protractor plugin to run aXe-core accessibility audits * Fixes a bunch of a11y issues in the e2e app to make the aXe audits green

…m browsers.

…fere with the tests.

devversion · 2016-12-11T20:24:13Z

@jelbourn This should be ready for another review.

The md-nav-list is making the link items bigger and the menus displayed differently.

Hiding them by default ensures that the links don't interfere with the specs.

jelbourn · 2016-12-12T18:42:51Z

@devversion Sounds like the menu tests are somewhat brittle, then...

What if we just made it not a nav-list at all and just used regular anchors?

devversion · 2016-12-12T18:46:36Z

@jelbourn Yep. The menu tests can always fail when the browser viewport is too small.

As long as the anchors don't take up too much space this should work.

I'd stick for now with the ngIf approach, because we might add other e2e pages here and we should make the menu tests stable in another PR.

devversion · 2016-12-13T19:48:21Z

@jelbourn Just rebased with the new Github functionality

Unfortunately you cannot just rebase and force-push with that.

dylanb · 2016-12-13T21:07:19Z

Yay!!

angular-automatic-lock-bot · 2019-09-06T05:02:09Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

devversion added the pr: needs review label Nov 28, 2016

devversion assigned jelbourn Nov 28, 2016

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 28, 2016

devversion force-pushed the chore/protractor-axe-core branch from 1449640 to 0fb1dd4 Compare November 28, 2016 19:45

devversion changed the title ~~echore: run a11y audits on protractor~~ chore: run a11y audits on protractor Nov 28, 2016

jelbourn reviewed Nov 28, 2016

View reviewed changes

devversion force-pushed the chore/protractor-axe-core branch from 0fb1dd4 to f2d1cc7 Compare November 29, 2016 17:49

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 29, 2016

tinayuangao added the pr: needs rebase label Dec 1, 2016

devversion force-pushed the chore/protractor-axe-core branch from f2d1cc7 to 9c5468a Compare December 1, 2016 14:44

devversion removed the pr: needs rebase label Dec 1, 2016

tinayuangao added the pr: needs rebase label Dec 1, 2016

devversion force-pushed the chore/protractor-axe-core branch from 9c5468a to 4eeef8d Compare December 2, 2016 18:10

devversion removed the pr: needs rebase label Dec 2, 2016

devversion added in progress This issue is currently in progress and removed action: merge The PR is ready for merge by the caretaker labels Dec 2, 2016

devversion force-pushed the chore/protractor-axe-core branch 3 times, most recently from 7a2d724 to af8df2f Compare December 11, 2016 18:49

devversion added 2 commits December 11, 2016 19:58

chore: run a11y audits on protractor

19536c1

* Fixes accessibility issue in grid-list with `role="listitem"` * Adds protractor plugin to run aXe-core accessibility audits * Fixes a bunch of a11y issues in the e2e app to make the aXe audits green

Force menu y-positions because viewport might be different on Seleniu…

3c30766

…m browsers.

devversion force-pushed the chore/protractor-axe-core branch from af8df2f to 3c30766 Compare December 11, 2016 19:21

Navigiation links should be hidden by default because those can inter…

6af517b

…fere with the tests.

devversion added pr: needs review and removed in progress This issue is currently in progress labels Dec 11, 2016

devversion requested a review from jelbourn December 11, 2016 20:25

jelbourn added action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 13, 2016

Merge branch 'master' into chore/protractor-axe-core

f3e70f7

jelbourn merged commit c5fb94f into angular:master Dec 13, 2016

devversion deleted the chore/protractor-axe-core branch December 13, 2016 20:11

devversion mentioned this pull request Dec 13, 2016

Run accessibility audit on CI #262

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: run a11y audits on protractor #2010

chore: run a11y audits on protractor #2010

Uh oh!

devversion commented Nov 28, 2016

Uh oh!

jelbourn Nov 28, 2016

Uh oh!

jelbourn Nov 28, 2016

Uh oh!

jelbourn Nov 28, 2016

Uh oh!

jelbourn Nov 28, 2016

Uh oh!

devversion Nov 29, 2016

Uh oh!

jelbourn Nov 28, 2016

Uh oh!

devversion Nov 29, 2016

Uh oh!

jelbourn commented Nov 29, 2016

Uh oh!

devversion commented Dec 2, 2016

Uh oh!

devversion commented Dec 11, 2016 •

edited

Loading

Uh oh!

jelbourn commented Dec 12, 2016

Uh oh!

devversion commented Dec 12, 2016

Uh oh!

devversion commented Dec 13, 2016

Uh oh!

dylanb commented Dec 13, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 6, 2019

Uh oh!

Uh oh!

chore: run a11y audits on protractor #2010

chore: run a11y audits on protractor #2010

Uh oh!

Conversation

devversion commented Nov 28, 2016

Uh oh!

jelbourn Nov 28, 2016

Choose a reason for hiding this comment

Uh oh!

jelbourn Nov 28, 2016

Choose a reason for hiding this comment

Uh oh!

jelbourn Nov 28, 2016

Choose a reason for hiding this comment

Uh oh!

jelbourn Nov 28, 2016

Choose a reason for hiding this comment

Uh oh!

devversion Nov 29, 2016

Choose a reason for hiding this comment

Uh oh!

jelbourn Nov 28, 2016

Choose a reason for hiding this comment

Uh oh!

devversion Nov 29, 2016

Choose a reason for hiding this comment

Uh oh!

jelbourn commented Nov 29, 2016

Uh oh!

devversion commented Dec 2, 2016

Uh oh!

devversion commented Dec 11, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jelbourn commented Dec 12, 2016

Uh oh!

devversion commented Dec 12, 2016

Uh oh!

devversion commented Dec 13, 2016

Uh oh!

dylanb commented Dec 13, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 6, 2019

Uh oh!

Uh oh!

devversion commented Dec 11, 2016 •

edited

Loading