test: clean up remaining dynamic query usages #20156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a while we had linting to explicitly specify the `static` flag on queries and we eventually removed it in ece8004, but there are still some PRs going in that were written while the restriction was in place. These changes clean up the remaining instances.
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion and
jelbourn
as code owners
googlebot
added
the
cla: yes
devversion
approved these changes
Aug 3, 2020
mmalerba
pushed a commit
that referenced
this pull request
Aug 5, 2020
For a while we had linting to explicitly specify the `static` flag on queries and we eventually removed it in ece8004, but there are still some PRs going in that were written while the restriction was in place. These changes clean up the remaining instances.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while we had linting to explicitly specify the
staticflag on queries and we eventually removed it in ece8004, but there are still some PRs going in that were written while the restriction was in place. These changes clean up the remaining instances.