feat(cdk-experimental/menu): enable keyboard handling for context menu #20171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Aug 3, 2020
| @@ -216,6 +216,7 @@ export class CdkContextMenuTrigger implements OnDestroy { | |||
|
|
|||
| this._contextMenuTracker.update(this); | |||
| this.open({x: event.clientX, y: event.clientY}); | |||
| this._menuPanel._menu?.focusFirstItem('mouse'); | |||
There was a problem hiding this comment.
I don't know that this should be mouse, since one could trigger this event with the keyboard.
There was a problem hiding this comment.
Referring to the fact that this method handles the keyboard shortcut to trigger a context menu??
There was a problem hiding this comment.
ok. As discussed, fixed to consider to clicked mouse button when setting focus
andy9775
force-pushed
the
cdk-menu-context-menu-keyhandling
branch
from
93f226b to
a16f8f3
Compare
By default on both Mac and Windows the context menu keyboard trigger is emitted as a contextmenu mouse event automatically, eliminating the need to handle keyboard events specifically for context menus. Therefore, this simply places focus on the first menu item in the opened context menu relying on the existing menu and menu item keyboard handling logic.
andy9775
force-pushed
the
cdk-menu-context-menu-keyhandling
branch
from
a16f8f3 to
9c18aec
Compare
jelbourn
reviewed
Aug 4, 2020
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default on both Mac and Windows the context menu keyboard trigger is emitted as a contextmenu
mouse event automatically, eliminating the need to handle keyboard events specifically for context
menus. Therefore, this simply places focus on the first menu item in the opened context menu
relying on the existing menu and menu item keyboard handling logic.