Skip to content

docs(material/button-toggle): update a11y section #20183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Aug 4, 2020

The docs for button-toggle were not updated when the control was
switched from using native checkboxes and radio-buttons to button
elements with aria-pressed. This change corrects the docs to reflect
the current state of the control.

@jelbourn jelbourn added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Aug 4, 2020
@jelbourn jelbourn requested a review from mmalerba August 4, 2020 15:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 4, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 4, 2020
The docs for button-toggle were not updated when the control was
switched from using native checkboxes and radio-buttons to button
elements with `aria-pressed`. This change corrects the docs to reflect
the current state of the control.
@jelbourn jelbourn force-pushed the button-toggle-docs branch from 9f6b1b7 to bb7b742 Compare August 4, 2020 19:01
@mmalerba mmalerba merged commit bb49835 into angular:master Aug 5, 2020
mmalerba pushed a commit that referenced this pull request Aug 5, 2020
The docs for button-toggle were not updated when the control was
switched from using native checkboxes and radio-buttons to button
elements with `aria-pressed`. This change corrects the docs to reflect
the current state of the control.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants