Combobox skeleton #20185
Merged
Combobox skeleton #20185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Aug 4, 2020
| selector: 'ng-template[cdkComboboxPanel]', | ||
| exportAs: 'cdkComboboxPanel', | ||
| host: { | ||
| 'role': 'combobox' |
There was a problem hiding this comment.
The panel here wouldn't be the element w/ role="combobox", it would be the trigger.
There was a problem hiding this comment.
Yeah that shouldn't have been there my mistake.
| 'role': 'combobox' | ||
| } | ||
| }) | ||
| export class CdkComboboxPanel<V = unknown> { |
There was a problem hiding this comment.
I'd probably prefer to use T as the template type here (and elsewhere)
jelbourn
added
merge: fix commit message
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created the skeleton for the combobox directive in cdk-experimental. Also added combobox to code owners.