Skip to content

docs(cdk/scrolling): make ScrollingModule the primary export (#20112) #20195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2020
Merged

docs(cdk/scrolling): make ScrollingModule the primary export (#20112) #20195

merged 1 commit into from
Aug 5, 2020

Conversation

howardjing
Copy link
Contributor

This designates ScrollingModule as the primary module for cdk/scrolling.

Fixes #20112

Screenshot:
image

@howardjing
docs(cdk/scrolling): make ScrollingModule the primary export (angular…
ae20157 
…#20112)

This designates ScrollingModule as the primary module for cdk/scrolling.

Fixes angular#20112
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2020
crisbeto
crisbeto approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Aug 5, 2020
@mmalerba mmalerba merged commit 32dcc17 into angular:master Aug 5, 2020
mmalerba pushed a commit that referenced this pull request Aug 5, 2020
@howardjing @mmalerba
docs(cdk/scrolling): make ScrollingModule the primary export (#20112) (…
b1bfcf0 
…#20195)

This designates ScrollingModule as the primary module for cdk/scrolling.

Fixes #20112
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(cdk/scrolling): Documentation for using cdk-virtual-scroll-viewport is incorrect
5 participants
@howardjing @crisbeto @devversion @googlebot @mmalerba