fix(cdk/drag-drop): preserve checked state for grouped radio inputs #20237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We transfer input `value` property while cloning draggable element, but with several radio inputs that have the same `name` attribute we can face an issue when checked state moves to cloned radio input element and we can't restore it when dropping element. These changes add unique name for all cloned elements: radio inputs inside preview and placeholder. This makes sure that original input won't lose its checked state once the clone is inserted in the DOM. Fixes angular#20236
googlebot
added
the
cla: yes
crisbeto
added
action: merge
wagnermaciel
pushed a commit
that referenced
this pull request
Aug 19, 2020
…20237) We transfer input `value` property while cloning draggable element, but with several radio inputs that have the same `name` attribute we can face an issue when checked state moves to cloned radio input element and we can't restore it when dropping element. These changes add unique name for all cloned elements: radio inputs inside preview and placeholder. This makes sure that original input won't lose its checked state once the clone is inserted in the DOM. Fixes #20236 (cherry picked from commit 8c336c9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We transfer input
valueproperty while cloning draggable element, butwith several radio inputs that have the same
nameattribute we can face anissue when checked state moves to cloned radio input element and we can't restore it
when dropping element.
These changes add unique name for all cloned elements: radio inputs
inside preview and placeholder. This makes sure that original input
won't lose its checked state once the clone is inserted in the DOM.
Fixes #20236