Skip to content

chore: clean up leftover tslint disable statements #20243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2020
Merged

chore: clean up leftover tslint disable statements #20243

merged 1 commit into from
Aug 12, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 7, 2020

These statements are from PRs that were opened before we added our own rule for validating class names.

@crisbeto
chore: clean up leftover tslint disable statements
30ff0c6 
These statements are from PRs that were opened before we added our own rule for validating class names.
@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Aug 7, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner August 7, 2020 20:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 7, 2020
mmalerba
mmalerba approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2020
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 12, 2020
@andrewseguin
Copy link
Contributor

Changing to minor due to conflicts with the patch branch

@andrewseguin andrewseguin merged commit 3828b7e into angular:master Aug 12, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @andrewseguin @devversion @mmalerba @googlebot