fix(datepicker): support dateClass on year and multi-year views #20256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Aug 11, 2020
| export type MatCalendarCellCssClasses = string | string[] | Set<string> | {[key: string]: any}; | ||
|
|
||
| /** Function that can generate the extra classes that should be added to a calendar cell. */ | ||
| export type MatCalendarCellClassFunction<D> = | ||
| (date: D, view: 'month' | 'year' | 'multi-year') => MatCalendarCellCssClasses; |
There was a problem hiding this comment.
Do we have a type alias for 'month' | 'year' | 'multi-year' somewhere? I thought we did, but I could be crazy
There was a problem hiding this comment.
I think we've just been doing it inline.
mmalerba
added
target: minor
|
I'm re-classifying this as |
We have a `dateClass` input that allows consumers to set classes to particular date cells, however currently we only invoke it inside the month view. These changes pass it along to the year and multi-year views too and provide the name of the view that invoked it so that cases like the first date of a month and a month cell can be distinguished. Fixes angular#20017.
crisbeto
force-pushed
the
20017/datepicker-date-class-views
branch
from
7870e38 to
d7a9ab6
Compare
|
I've reworked it based on the feedback. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a
dateClassinput that allows consumers to set classes to particular date cells, however currently we only invoke it inside the month view. These changes pass it along to the year and multi-year views too and provide the name of the view that invoked it so that cases like the first date of a month and a month cell can be distinguished.Fixes #20017.