build: do not consider e2e test targets as flaky locally #20371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running e2e test targets locally means that Bazel will re-run them a second time if they fail. This slows-down local development as there is no way to see the test failure before Bazel completed the second run. We should not consider e2e tests as flaky locally. Developers could re-run the test themselves if they see it being flaky. Also flaky e2e tests only seem to happen if lots of e2e tests execute concurrently. This is not often the case locally.
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
pushed a commit
that referenced
this pull request
Aug 28, 2020
Running e2e test targets locally means that Bazel will re-run them a second time if they fail. This slows-down local development as there is no way to see the test failure before Bazel completed the second run. We should not consider e2e tests as flaky locally. Developers could re-run the test themselves if they see it being flaky. Also flaky e2e tests only seem to happen if lots of e2e tests execute concurrently. This is not often the case locally. (cherry picked from commit fd34f35)
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
Running e2e test targets locally means that Bazel will re-run them a second time if they fail. This slows-down local development as there is no way to see the test failure before Bazel completed the second run. We should not consider e2e tests as flaky locally. Developers could re-run the test themselves if they see it being flaky. Also flaky e2e tests only seem to happen if lots of e2e tests execute concurrently. This is not often the case locally.
mmalerba
pushed a commit
that referenced
this pull request
Sep 2, 2020
Running e2e test targets locally means that Bazel will re-run them a second time if they fail. This slows-down local development as there is no way to see the test failure before Bazel completed the second run. We should not consider e2e tests as flaky locally. Developers could re-run the test themselves if they see it being flaky. Also flaky e2e tests only seem to happen if lots of e2e tests execute concurrently. This is not often the case locally.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running e2e test targets locally means that Bazel will re-run
them a second time if they fail. This slows-down local development
as there is no way to see the test failure before Bazel completed
the second run. We should not consider e2e tests as flaky locally.
Developers could re-run the test themselves if they see it being
flaky. Also flaky e2e tests only seem to happen if lots of e2e
tests execute concurrently. This is not often the case locally.