Skip to content

fix(material-experimental/mdc-dialog): blending in with background in high contrast mode #20387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

fix(material-experimental/mdc-dialog): blending in with background in high contrast mode #20387

merged 1 commit into from
Aug 28, 2020

Conversation

crisbeto
Copy link
Member

The MDC dialog was blending in with the page background, because it doesn't have a border or an outline.

@crisbeto
fix(material-experimental/mdc-dialog): blending in with background in…
1230b97 
… high contrast mode

The MDC dialog was blending in with the page background, because it doesn't have a border or an outline.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Aug 21, 2020
@crisbeto crisbeto requested a review from devversion as a code owner August 21, 2020 21:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 21, 2020
devversion
devversion approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 24, 2020
@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Aug 28, 2020
@jelbourn jelbourn merged commit 1219b1e into angular:master Aug 28, 2020
annieyw pushed a commit to annieyw/components that referenced this pull request Aug 31, 2020
@crisbeto @annieyw
fix(material-experimental/mdc-dialog): blending in with background in…
d0b575d 
… high contrast mode (angular#20387)

The MDC dialog was blending in with the page background, because it doesn't have a border or an outline.
mmalerba pushed a commit to mmalerba/components that referenced this pull request Sep 5, 2020
@crisbeto @mmalerba
fix(material-experimental/mdc-dialog): blending in with background in…
f15c2ad 
… high contrast mode (angular#20387)

The MDC dialog was blending in with the page background, because it doesn't have a border or an outline.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @jelbourn @googlebot