build: clean up uses of integers as booleans in Bazel files #20388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few places that are inconsistent by using `1` instead of `True`. Also fixes one place where we were using the incorrect wording in a license header.
crisbeto
added
merge safe
P4
googlebot
added
the
cla: yes
devversion
approved these changes
Aug 24, 2020
There was a problem hiding this comment.
LGTM. Looks like there is no buildifier rule we can enable: https://github.com/bazelbuild/buildtools/blob/master/WARNINGS.md
jelbourn
pushed a commit
that referenced
this pull request
Aug 25, 2020
Fixes a few places that are inconsistent by using `1` instead of `True`. Also fixes one place where we were using the incorrect wording in a license header. (cherry picked from commit 6103b74)
annieyw
pushed a commit
to annieyw/components
that referenced
this pull request
Aug 31, 2020
…20388) Fixes a few places that are inconsistent by using `1` instead of `True`. Also fixes one place where we were using the incorrect wording in a license header.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few places that are inconsistent by using
1instead ofTrue.Also fixes one place where we were using the incorrect wording in a license header.