perf(cdk/testing): Improve performance of clicking in unit tests. #20441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
P2
googlebot
added
the
cla: yes
crisbeto
reviewed
Aug 28, 2020
mmalerba
force-pushed
the
harness-perf-1
branch
2 times, most recently
from
5ce644d to
306e60d
Compare
devversion
approved these changes
Aug 28, 2020
mmalerba
force-pushed
the
harness-perf-1
branch
from
2e9a9f7 to
4ee107d
Compare
This PR changes the semantics of `TestElement.click()` when called with
no arguments. Rather than guarantee clicking the center of the element,
the location of the click will be up to the particular
`HarnessEnvironment`. This allows the `TestbedHarnessEnvironment` to
skip the expensive and often unnecessary calculation to determine the
center of the element.
To replace the old behavior of `TestElement.click()`, the PR adds a new
signature, `TestElement.click('center')` that can be used to click the
center of the element. Calling `TestElement.click(x, y)` to click a
point relative to the top left of the element remains uncahnged.
I tested the performance gain of these changes by running a unit test to
click 1000 buttons. Prior to this change it took 3000.2ms, with this
change it took 1842.1ms (38.6% improvement).
mmalerba
force-pushed
the
harness-perf-1
branch
from
dafd8f6 to
9c0df7d
Compare
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Sep 24, 2020
…gular#20441) * perf(cdk/testing): Improve performance of clicking in unit tests. This PR changes the semantics of `TestElement.click()` when called with no arguments. Rather than guarantee clicking the center of the element, the location of the click will be up to the particular `HarnessEnvironment`. This allows the `TestbedHarnessEnvironment` to skip the expensive and often unnecessary calculation to determine the center of the element. To replace the old behavior of `TestElement.click()`, the PR adds a new signature, `TestElement.click('center')` that can be used to click the center of the element. Calling `TestElement.click(x, y)` to click a point relative to the top left of the element remains uncahnged. I tested the performance gain of these changes by running a unit test to click 1000 buttons. Prior to this change it took 3000.2ms, with this change it took 1842.1ms (38.6% improvement). * update API golds * address comments * allow users to specify location of button click * fix type of click args * test(material-experimental/mdc-tabs): fix tab harness
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the semantics of
TestElement.click()when called withno arguments. Rather than guarantee clicking the center of the element,
the location of the click will be up to the particular
HarnessEnvironment. This allows theTestbedHarnessEnvironmenttoskip the expensive and often unnecessary calculation to determine the
center of the element.
To replace the old behavior of
TestElement.click(), the PR adds a newsignature,
TestElement.click('center')that can be used to click thecenter of the element. Calling
TestElement.click(x, y)to click apoint relative to the top left of the element remains unchanged.
I tested the performance gain of these changes by running a unit test to
click 1000 buttons. Prior to this change it took 3000.2ms, with this
change it took 1842.1ms (38.6% improvement).