Skip to content

refactor(datepicker): remove deprecated APIs for v11 #20449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2020

Conversation

crisbeto
Copy link
Member

Removes the APIs that were marked as deprecated for v11 in the datepicker module.

BREAKING CHANGES:

  • The value emitted by MatCalendar.selectedChange can now be null.
  • MatDatepickerInput.getPopupConnectionElementRef has been removed. Use getConnectedOverlayOrigin instead.
  • The _changeDetectorRef, _model, _dateAdapter and _rangeSelectionStrategy parameters of the MatDatepickerContent constructor are now required.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Aug 28, 2020
@crisbeto crisbeto added this to the 11.0.0 milestone Aug 28, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 28, 2020
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Aug 28, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2020
@mmalerba
Copy link
Contributor

mmalerba commented Sep 2, 2020

@crisbeto needs rebase

Removes the APIs that were marked as deprecated for v11 in the datepicker module.

BREAKING CHANGES:
* The value emitted by `MatCalendar.selectedChange` can now be null.
* `MatDatepickerInput.getPopupConnectionElementRef` has been removed. Use `getConnectedOverlayOrigin` instead.
* The `_changeDetectorRef`, `_model`, `_dateAdapter` and `_rangeSelectionStrategy` parameters of the `MatDatepickerContent` constructor are now required.
@crisbeto crisbeto force-pushed the datepicker-v11-breaking-changes branch from 02c00c5 to 0fecc80 Compare September 3, 2020 07:05
@crisbeto
Copy link
Member Author

crisbeto commented Sep 3, 2020

Rebased.

@mmalerba mmalerba merged commit 7510f4c into angular:master Sep 5, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants