build: add a script to flag missing unit tests in MDC packages #20471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
commented
Sep 1, 2020
| @@ -3,6 +3,7 @@ | |||
| "outDir": "../dist/dev-infra-scripts", | |||
| "target": "es2015", | |||
| "lib": ["es2016"], | |||
| "moduleResolution": "node", | |||
There was a problem hiding this comment.
This was necessary, because vscode was flagging any imports to node_modules dependencies as invalid.
devversion
reviewed
Sep 2, 2020
| @@ -45,7 +45,8 @@ | |||
| "approve-size-tests": "node ./scripts/approve-size-golden.js", | |||
| "integration-tests": "bazel test --test_tag_filters=-view-engine-only --build_tests_only -- //integration/... -//integration/size-test/...", | |||
| "integration-tests:view-engine": "bazel test --test_tag_filters=view-engine-only --build_tests_only -- //integration/... -//integration/size-test/...", | |||
| "integration-tests:size-test": "bazel test //integration/size-test/..." | |||
| "integration-tests:size-test": "bazel test //integration/size-test/...", | |||
| "check-mdc-tests": "ts-node --project scripts/tsconfig.json scripts/check-mdc-tests.ts" | |||
There was a problem hiding this comment.
Is this something manually to be run, or can we wire it up in CI?
There was a problem hiding this comment.
The idea is to eventually run it on the CI, but I wanted to add all the missing tests first and it still needs a way to exclude some tests that are irrelevant for the MDC version.
Adds a script that will find and log out the names of Material unit tests that don't exist in the equivalent MDC component. Note that right now it's something we'd run manually, but the idea is to eventually have it on the CI, once all the tests have been added and we have the ability to exclude some tests that aren't relevant for MDC.
crisbeto
force-pushed
the
mdc-unit-test-script
branch
from
a1b5216 to
37b39b0
Compare
|
The feedback has been addressed. |
mmalerba
pushed a commit
that referenced
this pull request
Sep 2, 2020
Adds a script that will find and log out the names of Material unit tests that don't exist in the equivalent MDC component. Note that right now it's something we'd run manually, but the idea is to eventually have it on the CI, once all the tests have been added and we have the ability to exclude some tests that aren't relevant for MDC. (cherry picked from commit 42fb35b)
mmalerba
pushed a commit
that referenced
this pull request
Sep 2, 2020
Adds a script that will find and log out the names of Material unit tests that don't exist in the equivalent MDC component. Note that right now it's something we'd run manually, but the idea is to eventually have it on the CI, once all the tests have been added and we have the ability to exclude some tests that aren't relevant for MDC.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script that will find and log out the names of Material unit tests that don't exist in the equivalent MDC component. Note that right now it's something we'd run manually, but the idea is to eventually have it on the CI, once all the tests have been added and we have the ability to exclude some tests that aren't relevant for MDC.