-
Notifications
You must be signed in to change notification settings - Fork 6.8k
refactor(core): remove deprecated APIs for v11 #20479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. one minor comment
8e92ade
to
d8d9093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d8d9093
to
cc8e65e
Compare
cc8e65e
to
adee7a1
Compare
@crisbeto Please resolve this merge conflict |
Rebased. |
c5d506d
to
c46aa64
Compare
@crisbeto I think the recently merged mdc_select was using |
c46aa64
to
cef436e
Compare
Fixed. |
Removes the deprecated APIs for v11 from `material/core`. Also fixes the fact that the MDC-based form field doesn't support the global `floatLabel` option. BREAKING CHANGES: * `MAT_LABEL_GLOBAL_OPTIONS` from `material/core` has been removed. Import `MAT_FORM_FIELD_DEFAULT_OPTIONS` from `material/form-field` instead. * `FloatLabelType` from `material/core` has been removed. Import `FloatLabelType` from `material/form-field` instead. * `LabelOptions` from `material/core` has been removed. Import `MatFormFieldDefaultOptions` from `material/form-field` instead. * `MAT_DATE_LOCALE_PROVIDER` has been removed, because it is no longer needed since MAT_DATE_LOCALE has been changed to a scoped injectable. If you are importing and providing this in your code you can simply remove it. * `MatLineSetter` class has been removed. Use the `setLines` function instead. * `hammer` property from `GranularSanityChecks` has been removed, because it isn't being used anymore. * `document` parameter of the `MatCommonModule` constructor is now required.
cef436e
to
815d368
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes the deprecated APIs for v11 from
material/core
. Also fixes that the MDC-based form field doesn't support the globalfloatLabel
option.BREAKING CHANGES:
MAT_LABEL_GLOBAL_OPTIONS
frommaterial/core
has been removed. ImportMAT_FORM_FIELD_DEFAULT_OPTIONS
frommaterial/form-field
instead.FloatLabelType
frommaterial/core
has been removed. ImportFloatLabelType
frommaterial/form-field
instead.LabelOptions
frommaterial/core
has been removed. ImportMatFormFieldDefaultOptions
frommaterial/form-field
instead.MAT_DATE_LOCALE_PROVIDER
has been removed, because it is no longer needed since MAT_DATE_LOCALE has been changed to a scoped injectable. If you are importing and providing this in your code you can simply remove it.MatLineSetter
class has been removed. Use thesetLines
function instead.hammer
property fromGranularSanityChecks
has been removed, because it isn't being used anymore.document
parameter of theMatCommonModule
constructor is now required.