Skip to content

refactor(core): remove deprecated APIs for v11 #20479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 2, 2020

Removes the deprecated APIs for v11 from material/core. Also fixes that the MDC-based form field doesn't support the global floatLabel option.

BREAKING CHANGES:

  • MAT_LABEL_GLOBAL_OPTIONS from material/core has been removed. Import MAT_FORM_FIELD_DEFAULT_OPTIONS from material/form-field instead.
  • FloatLabelType from material/core has been removed. Import FloatLabelType from material/form-field instead.
  • LabelOptions from material/core has been removed. Import MatFormFieldDefaultOptions from material/form-field instead.
  • MAT_DATE_LOCALE_PROVIDER has been removed, because it is no longer needed since MAT_DATE_LOCALE has been changed to a scoped injectable. If you are importing and providing this in your code you can simply remove it.
  • MatLineSetter class has been removed. Use the setLines function instead.
  • hammer property from GranularSanityChecks has been removed, because it isn't being used anymore.
  • document parameter of the MatCommonModule constructor is now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Sep 2, 2020
@crisbeto crisbeto added this to the 11.0.0 milestone Sep 2, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 2, 2020
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. one minor comment

@crisbeto crisbeto force-pushed the core-v11-breaking-changes branch from 8e92ade to d8d9093 Compare September 2, 2020 18:08
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 2, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto force-pushed the core-v11-breaking-changes branch from d8d9093 to cc8e65e Compare September 4, 2020 13:29
@crisbeto crisbeto force-pushed the core-v11-breaking-changes branch from cc8e65e to adee7a1 Compare September 16, 2020 15:24
@wagnermaciel
Copy link
Contributor

@crisbeto Please resolve this merge conflict

@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto force-pushed the core-v11-breaking-changes branch 3 times, most recently from c5d506d to c46aa64 Compare September 23, 2020 09:05
@annieyw
Copy link
Contributor

annieyw commented Sep 23, 2020

@crisbeto I think the recently merged mdc_select was using MAT_LABEL_GLOBAL_OPTIONS can you switch it to MAT_FORM_FIELD_DEFAULT_OPTIONS?

@crisbeto crisbeto force-pushed the core-v11-breaking-changes branch from c46aa64 to cef436e Compare September 24, 2020 05:59
@crisbeto
Copy link
Member Author

Fixed.

Removes the deprecated APIs for v11 from `material/core`. Also fixes the fact that
the MDC-based form field doesn't support the global `floatLabel` option.

BREAKING CHANGES:
* `MAT_LABEL_GLOBAL_OPTIONS` from `material/core` has been removed. Import
`MAT_FORM_FIELD_DEFAULT_OPTIONS` from `material/form-field` instead.
* `FloatLabelType` from `material/core` has been removed. Import `FloatLabelType` from
`material/form-field` instead.
* `LabelOptions` from `material/core` has been removed. Import `MatFormFieldDefaultOptions` from
`material/form-field` instead.
* `MAT_DATE_LOCALE_PROVIDER` has been removed, because it is no longer needed since MAT_DATE_LOCALE
has been changed to a scoped injectable. If you are importing and providing this in your code you
can simply remove it.
* `MatLineSetter` class has been removed. Use the `setLines` function instead.
* `hammer` property from `GranularSanityChecks` has been removed, because it isn't being used
anymore.
* `document` parameter of the `MatCommonModule` constructor is now required.
@crisbeto crisbeto force-pushed the core-v11-breaking-changes branch from cef436e to 815d368 Compare September 29, 2020 18:40
@mmalerba mmalerba merged commit e99ca0a into angular:master Sep 29, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants