Skip to content

docs(guide/using-component-harnesses): fix typo "synax" to "syntax" #20518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

davlasry
Copy link
Contributor

@davlasry davlasry commented Sep 9, 2020

fix(material/docs): typo "synax" to "syntax"

@davlasry davlasry requested a review from jelbourn as a code owner September 9, 2020 12:19
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Sep 9, 2020
@davlasry
Copy link
Contributor Author

davlasry commented Sep 9, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 9, 2020
@davlasry
Copy link
Contributor Author

davlasry commented Sep 9, 2020

Can someone help me figure out what "Pending - Missing required labels: target: *" mean?

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Commit message fixup: should be scoped to docs, not fix.

@crisbeto crisbeto added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Sep 9, 2020
@davlasry davlasry changed the title fix(material/docs): typo "synax" to "syntax" docs(using-component-harnesses): typo "synax" to "syntax" Sep 9, 2020
@davlasry davlasry changed the title docs(using-component-harnesses): typo "synax" to "syntax" docs(cdk/using-component-harnesses): typo "synax" to "syntax" Sep 9, 2020
@davlasry davlasry changed the title docs(cdk/using-component-harnesses): typo "synax" to "syntax" docs(guide/using-component-harnesses): typo "synax" to "syntax" Sep 9, 2020
@davlasry davlasry changed the title docs(guide/using-component-harnesses): typo "synax" to "syntax" docs(guide/using-component-harnesses): fix typo "synax" to "syntax" Sep 9, 2020
@andrewseguin andrewseguin merged commit 7b00da2 into angular:master Sep 11, 2020
andrewseguin pushed a commit that referenced this pull request Sep 11, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants