build: setup default browser for running legacy tests locally #20620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the legacy Karma tests might fail and one might want to debug those. Currently the Gulp task can be run for that, but it's not starting any browser so one needs to launch Chrome manually. Tests usually fail then because the browser has different dimensions but our test expectations rely on a specific dimension. i.e. 1024x768
devversion
added
merge safe
target: patch
googlebot
added
the
cla: yes
annieyw
pushed a commit
that referenced
this pull request
Sep 22, 2020
Sometimes the legacy Karma tests might fail and one might want to debug those. Currently the Gulp task can be run for that, but it's not starting any browser so one needs to launch Chrome manually. Tests usually fail then because the browser has different dimensions but our test expectations rely on a specific dimension. i.e. 1024x768 (cherry picked from commit e8265cc)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the legacy Karma tests might fail and one might want
to debug those. Currently the Gulp task can be run for that, but
it's not starting any browser so one needs to launch Chrome manually.
Tests usually fail then because the browser has different dimensions
but our test expectations rely on a specific dimension. i.e. 1024x768