fix(material/select): option active styling not removed when value is changed programmatically #20649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
… changed programmatically If an option is selected by the user and the value is changed programmatically afterwards, we weren't removing the active state from the previous option. This seems to be a regression from angular#19970. These changes resolve the issue and preserve the fix from angular#19970 by resetting the active styling manually.
crisbeto
force-pushed
the
select-option-active-reset
branch
from
2871024 to
72be295
Compare
mmalerba
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an option is selected by the user and the value is changed programmatically afterwards, we weren't removing the active state from the previous option. This seems to be a regression from #19970.
These changes resolve the issue and preserve the fix from #19970 by resetting the active styling manually.